Skip to content

BUG: Improve dimension-dependent BSplineInterpolationWeightFunction wrapping#2729

Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:releasefrom
thewtex:fix-array-dimensions-4
Sep 10, 2021
Merged

BUG: Improve dimension-dependent BSplineInterpolationWeightFunction wrapping#2729
thewtex merged 1 commit intoInsightSoftwareConsortium:releasefrom
thewtex:fix-array-dimensions-4

Conversation

@thewtex
Copy link
Member

@thewtex thewtex commented Sep 9, 2021

Avoid build errors when we wrap for 4-D images.

@thewtex thewtex changed the base branch from master to release September 9, 2021 19:45
@thewtex thewtex requested review from N-Dekker and dzenanz September 9, 2021 19:45
@github-actions github-actions bot added area:Core Issues affecting the Core module area:Python wrapping Python bindings for a class type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances labels Sep 9, 2021
…rapping

Avoid build errors when we wrap for 4-D images.
@thewtex thewtex force-pushed the fix-array-dimensions-4 branch from 6445230 to 61f98c7 Compare September 10, 2021 01:48
@N-Dekker
Copy link
Contributor

@thewtex Just for my understanding, did my commit 9bf745b (Use FixedArray for BSplineInterpolationWeightFunction OutputType, PR #2712) cause a problem, that you're addressing here? I thought the CI was green for PR #2712!

@thewtex
Copy link
Member Author

thewtex commented Sep 10, 2021

@N-Dekker yes, we did not see the failure in CI because CI does not build 4-D for efficiency.

Merging for the 5.3 RC 1 Python packages.

@thewtex thewtex merged commit 30cd5fa into InsightSoftwareConsortium:release Sep 10, 2021
@thewtex thewtex deleted the fix-array-dimensions-4 branch September 10, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Core Issues affecting the Core module area:Python wrapping Python bindings for a class type:Bug Inconsistencies or issues which will cause an incorrect result under some or all circumstances

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants